PP-11232 Add method to find transactions for redaction #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added method to find transactions between a date range for redaction. This is to incrementally find transactions and redact PII from transactions.
jfharden
approved these changes
Sep 19, 2023
jfharden
reviewed
Sep 19, 2023
|
|
||
| import java.time.ZonedDateTime; | ||
| import java.time.temporal.ChronoUnit; |
There was a problem hiding this comment.
Do you need this? I can't see any uses of it in the tests? I was wondering if bringing it in causes some other behaviour?
There was a problem hiding this comment.
Good spot! it is not not required. I have used it in the test but removed it later. Will remove it in the next PR.
There was a problem hiding this comment.
Shouldn't cause any behavioural changes.
There was a problem hiding this comment.
I have to remember I'm not in ruby land anymore, I'm so used to things in ruby being require'd and then changing the behaviour of everything without ever being referenced directly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT